feat: Add list nodes for timestamped comments #16530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue was super informative: ueberdosis/tiptap#1403 |
daibhin
commented
Jul 13, 2023
| const isEmpty = !hasContent(props.node) | ||
|
|
||
| if (!isEmpty && !playbackTime) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
I was seeing the same error @pauldambra faced in #16415 (comment). Adding a very short timeout worked but I feel like there has to be a better way here
daibhin
commented
Jul 13, 2023
| @@ -60,3 +63,35 @@ export function externalLinkPasteRule(options: { | |||
| }, | |||
| }) | |||
| } | |||
|
|
|||
| export function nodePasteRule(config: { | |||
There was a problem hiding this comment.
I had to reimplement the nodePasteRule because it didn't allow for content to be inserted when creating a node. Opened a PR to fix that in a future version: ueberdosis/tiptap#4212
|
Closing in favour of #16613 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Towards #15680
We don't currently support any type of comments in recordings
Changes
How did you test this code?
Doesn't actually add any new functionality. Simply adds new node types. Will implement comments using these nodes in a future PR