-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane from trace #17
Plane from trace #17
Conversation
… seismic hazard for the 2010 NSHM.
The latest commit has two changes:
|
@claudio525 I have made a few changes:
|
…g into plane_from_trace - Fixed conflicts manually
@lispandfound I was working on this last night and this morning without realising that you had made changes, so have just combined our changes. |
…g into plane_from_trace
@claudio525 I made a couple of changes:
|
…g into plane_from_trace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small change left!
plane = Plane.from_nztm_trace( | ||
trace_points_nztm, dtop, dtop + depth, dip, dip_dir_nztm=dip_dir_nztm | ||
) | ||
assert pytest.approx(plane.top_m, abs=1e-3) == dtop * 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of abs varies from 1e-6 (strike_nztm, dip) to 10 (dip_dir). Was it determined empirically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of abs varies from 1e-6 (strike_nztm, dip) to 10 (dip_dir). Was it determined empirically?
The tolerance on dip direction is 0.1. Yes some of these values have higher tolerances because they are subject to greater variation and numerical error. The great circle bearings in particular are very finicky to get right.
2e6650b
plane = Plane.from_nztm_trace( | ||
trace_points_nztm, dtop, dtop + depth, dip, dip_dir_nztm=dip_dir_nztm | ||
) | ||
assert pytest.approx(plane.top_m, abs=1e-3) == dtop * 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of abs varies from 1e-6 (strike_nztm, dip) to 10 (dip_dir). Was it determined empirically?
The tolerance on dip direction is 0.1. Yes some of these values have higher tolerances because they are subject to greater variation and numerical error. The great circle bearings in particular are very finicky to get right.
Build on top of #14, so that needs to be merged first.
source_modelling/source_modelling/sources.py
Line 286 in d22d5f0