feat(nshm_db_generator): Use the from_trace method #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispandfound
requested review from
sungeunbae,
joelridden,
claudio525 and
AndrewRidden-Harper
joelridden
reviewed
Jan 31, 2025
AndrewRidden-Harper
approved these changes
Feb 3, 2025
|
Tests will fail till ucgmsim/source_modelling#17 merges. |
claudio525
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
from_nztm_tracefunction to construct planes,The latter point takes care of faults that have tiny segments that pose a problem for numerical accuracy and SRF generation. You can see examples of the simplified traces below:
There is a red trace in that same plot that is supposed to be the new trace, but it's so similar to the old trace that it is hard to distinguish.