Bump Barstools for Deprecations Fixes #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should have someone who is actively using hammer also test with this branch ideally. I think the barstools code paths for that are different than the CI. |
|
I'll try. |
.circleci/config.yml
Outdated
| @@ -12,7 +12,7 @@ parameters: | |||
| executors: | |||
| main-env: | |||
| docker: | |||
| - image: ucbbar/chipyard-image:1.0.1 | |||
| - image: ucbbar/chipyard-ci-image:84cfc73 | |||
There was a problem hiding this comment.
For this PR, can you revert this change. Just modify the timeout settings and not this image.
There was a problem hiding this comment.
Reverted docker change, and re-changed lines 115 and 234 to use 20m timeout
|
The macrocompiler flow still seems to work fine. |
jerryz123
approved these changes
Feb 22, 2021
abejgonzalez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs: ucb-bar/barstools#98 ucb-bar/barstools#97
Type of change: removing deprecated code from barstools
Impact: No impact except less warnings
Release Notes
Removed deprecated Driver code from barstools