This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Fix deprecations 1 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests run as they did prior to the changes
- Mostly this reformat comments and large argument lists to classes and methods
- Mostly this reformat comments and large argument lists to classes and methods
- Mostly this reformat comments and large argument lists to classes and methods
Requires updating to AnyFlatSpec where used And different import for Matchers
- Fix name reference and weird .get.get in CostMetric - Update to DependencyAPIMigration - MacroCompilerTransform - MacroCompilerOptimizations - Delete unused class MacroCompiler - Remove use of ExecutionOptionsManager in object MacroCompiler - Removed stack trace when no arguments from CLI, just give message requiring args - Update version to 0.4-SNAPSHOT
…tted name - Changed packages in tapeout/transforms/utils/*.scala to be in their own package `utils`
This was referenced Feb 10, 2021
abejgonzalez
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
LGTM. If you can just update the PR description to talk about the other PRs that were merged in here that would be great. Also, the Chipyard PR can be updated with the merged master commit or we can wait until all deprecations are solved to do a "big" PR with everything in 1 go.
|
I vote for updating chipyard once when the dust settles on this and a forthcoming PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be merged after pr#95 and PR #96
Remove deprecated Driver stuff macros package
- MacroCompilerTransform
- MacroCompilerOptimizations
Includes commits for standardizing code