Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use custom repos provided by akmods #236

Merged
merged 3 commits into from
May 31, 2023
Merged

feat: use custom repos provided by akmods #236

merged 3 commits into from
May 31, 2023

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented May 30, 2023

Related to ublue-os/akmods#4 and depends on the merge of ublue-os/akmods#16

This PR does set a precedent for how we will do akmods moving forward, specifically, in the use of custom/3rd-party repos for akmods which are NOT part of rpmfusion. So that's specifically where I want some feedback.

@bsherman bsherman marked this pull request as ready for review May 30, 2023 16:15
@bsherman bsherman requested a review from castrojo as a code owner May 30, 2023 16:15
@bsherman bsherman requested a review from akdev1l May 30, 2023 16:15
@bsherman
Copy link
Contributor Author

Build failures were expected initially as we've not merged the dependency ublue-os/akmods#16. Once that is done and builds, this PR should build clean.

@bsherman bsherman marked this pull request as draft May 31, 2023 03:44
@bsherman
Copy link
Contributor Author

I've improved akmods' distribution of 3rd party repo files by adding them into the akdmods addons RPM, which this now consumes properly.

@bsherman bsherman marked this pull request as ready for review May 31, 2023 06:18
@bsherman bsherman enabled auto-merge May 31, 2023 06:19
@bsherman
Copy link
Contributor Author

bsherman commented May 31, 2023

This should build cleanly after ublue-os/akmods#16 has merged, built, and a new akmods image is published with the ublue-os-akmods-addons*.rpm.

@bsherman bsherman added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit efe5364 May 31, 2023
@bsherman bsherman deleted the akmods-with-repos branch May 31, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants