Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xbox controller kmods #16

Merged
merged 2 commits into from
May 31, 2023
Merged

feat: add xbox controller kmods #16

merged 2 commits into from
May 31, 2023

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented May 30, 2023

Adds both xone and xpadneo xbox controller akmods.

Creates a /repos subdir in resulting akmods image to ensure consumers have access to the 3rd party repos used to build kmods which are not in rpmfusion.

This PR does set a precedent for how we will do akmods moving forward, specifically, in the use of custom/3rd-party repos for akmods which are NOT part of rpmfusion. So that's specifically where I want some feedback. (see ublue-os/main#236 for how these are consumed)

Closes #4

@bsherman bsherman marked this pull request as ready for review May 30, 2023 16:14
@bsherman bsherman requested a review from castrojo as a code owner May 30, 2023 16:14
@bsherman bsherman requested a review from akdev1l May 30, 2023 16:15
@bsherman
Copy link
Contributor Author

bsherman commented May 30, 2023

Here's an example why i wanted this PR to sit and bake a bit and get some other eyes on it. I knew I wasn't super happy with the approach I was taking... just copying around .repo files...

As I was prepping the nvidia signing key cutover PR a potential answer was right in my face.

We already have 3rd party repos used which we distribute in the ublue-os-nvidia-addons RPM: https://github.com/ublue-os/nvidia/blob/main/ublue-os-nvidia-addons.spec#L14

So probably, in this repo, we need to rename ublue-os-akmods-key RPM to ublue-os-akmods-addons and add custom repos to that, or something similar... seems like a cleaner solution.

@bsherman bsherman marked this pull request as draft May 31, 2023 03:43
Provides 3rd party repos (negativo17 at ths time) in the
ublue-os-akmods-addons RPM, formerly named ublue-os-akmods-key.
@bsherman bsherman marked this pull request as ready for review May 31, 2023 06:13
@bsherman
Copy link
Contributor Author

I've improved this by putting extra, 3rd party repos into the akdmods addons RPM.

@bsherman bsherman added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit 7783128 May 31, 2023
@bsherman bsherman deleted the enable-xbox branch May 31, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add xbox controller drivers
2 participants