chore: refactor ISO build workflow to use isogenerator outputs #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p5
requested review from
noelmiller and
castrojo
and removed request for
castrojo
castrojo
approved these changes
Mar 1, 2024
castrojo
approved these changes
Mar 1, 2024
awesomekyle
pushed a commit
to awesomekyle/bluefin
that referenced
this pull request
Apr 24, 2024
…-os#982) Co-authored-by: Noel Miller <[email protected]> Co-authored-by: Jorge O. Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #986
Refactors the workflow to use the action outputs rather than hard-coding the ./end_iso directory.
Also moved the environment variables from the rclone step to
envarguments instead of defining them in the script.Finally setup the workflow to upload ISOs and checksums to job artifacts on PRs which touch the build workflow.