Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Tests for Building ISOs #986

Closed
noelmiller opened this issue Feb 29, 2024 · 3 comments · Fixed by #982
Closed

Write Tests for Building ISOs #986

noelmiller opened this issue Feb 29, 2024 · 3 comments · Fixed by #982
Assignees

Comments

@noelmiller
Copy link
Member

I would like tests before a new version of the build_iso.yml workflow is merged. This is similar to the testing we do in the actual isogenerator action. (do not have it upload to R2, have it upload as an artifact so we can review the ISO it created)

There should be no reason we are building all the container images when we are updating the build_iso.yml workflow as they exist independently of each other

@p5
Copy link
Member

p5 commented Feb 29, 2024

There should be no reason we are building all the container images when we are updating the build_iso.yml workflow as they exist independently of each other

I'm not too sure how we will do this. The container builds are required checks of the repo, so we can't really skip them.

@noelmiller
Copy link
Member Author

I think we can have it ignore the check for certain files? You would want to consult @castrojo on that. I think @KyleGospo does it in the Bazzite repo.

@castrojo
Copy link
Member

Yeah, we can add the ignore later? Does it matter if it's kicking off builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants