Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include minimum jvm version in launch command #10

Merged
merged 1 commit into from
Jun 13, 2024
Merged

include minimum jvm version in launch command #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export class BazelBSPInstaller {
.join(' ')

// Full install command including flags.
const installCommand = `"${coursierPath}" launch ${MAVEN_PACKAGE}:${config.serverVersion} -M ${INSTALL_METHOD} -- ${flagsString}`
const installCommand = `"${coursierPath}" launch --jvm 11+ ${MAVEN_PACKAGE}:${config.serverVersion} -M ${INSTALL_METHOD} -- ${flagsString}`

// Report progress in output channel.
const installProcess = cp.spawn(installCommand, {cwd: root, shell: true})
Expand Down
1 change: 1 addition & 0 deletions src/test/suite/install.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ suite('BSP Installer', () => {

// Just confirm that coursier path was part of the spawn call, to leave flexibility for other changes to the command.
assert.ok(spawnStub.getCalls()[0].args[0].includes(coursierPath))
assert.ok(spawnStub.getCalls()[0].args[0].includes('--jvm 11+'))
assert.ok(installResult)
})

Expand Down
Loading