Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include minimum jvm version in launch command #10

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Jun 13, 2024

(migrating existing commit from internal repo)

Specify minimum --jvm argument when launching the BSP install command. This will allow coursier to attempt to find a version that matches if already installed, or download one that meets the requirements. This ensures a successful launch even in environments that do not have a new enough jvm version installed.

@mnoah1 mnoah1 marked this pull request as ready for review June 13, 2024 17:41
Copy link
Collaborator

@shuklahy shuklahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuklahy shuklahy merged commit 8637992 into main Jun 13, 2024
4 checks passed
@mnoah1 mnoah1 deleted the jvm-min-ver branch June 13, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants