Add python 3.12 wheels on v3.7 #344
Conversation
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #344 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 425 425
=========================================
Hits 425 425 ☔ View full report in Codecov by Sentry. |
|
This does not seem to be building correctly? https://github.com/uber/h3-py/actions/runs/8047484474/job/22005886719?pr=344 |
Yeah, the cibuildwheel version did not support python 3.12 yet. I upgraded to the newest one. The earliest stable ABI was in version 2.15, with the final CPython 3.12 in v2.16.2. |
* Drop cibuildwheel v1 and 3.5 tests * try [email protected] * drop down to [email protected] * bump ubuntu from 20.04 to 22.04 * Revert "bump ubuntu from 20.04 to 22.04" This reverts commit f94bea6. * bump Python version from 3.8 to 3.11 for coverage/lint and docs * bump cibuildwheel
|
I cherry-picked some commits from main dropping c1 builds and python 2.7 & 3.5. I also added a commit dropping 3.6. |
|
The cherry-picking seems to have overwritten the cibuildversion to 2.16.2 instead of 2.16.5, but that should be fine as it contains a final CPython version for 3.12. I have no idea why the windows build failed and this is as far as I am taking this PR. |
|
Upgraded cibuildwheel back to 2.16.5 as this might be the cause of the windows build issues. |
|
All green. |
|
This looks good. Thanks @msaecker! |
Extend the exisiting build pipeline to create python 3.12 wheels.