Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python version 3.12 #342

Closed
josteinl opened this issue Feb 8, 2024 · 7 comments
Closed

Support Python version 3.12 #342

josteinl opened this issue Feb 8, 2024 · 7 comments

Comments

@josteinl
Copy link

josteinl commented Feb 8, 2024

Add support for Python version 3.12 would be much appreciated.

Think this is somewhat relevant for #326.

@msaecker
Copy link

I tried my hand at extending the build pipeline to create python 3.12 wheels #344

@mborus
Copy link

mborus commented Feb 29, 2024

I tried my hand at extending the build pipeline to create python 3.12 wheels #344

This is great news. Could you also consider having the pipeline created wheels uploaded to a folder in this repo? This would make it easier to download it for offline and see which wheels are available.

@msaecker
Copy link

msaecker commented Mar 4, 2024

I tried my hand at extending the build pipeline to create python 3.12 wheels #344

This is great news. Could you also consider having the pipeline created wheels uploaded to a folder in this repo? This would make it easier to download it for offline and see which wheels are available.

Sorry, I wanted to do a minimal change to support python 3.12 and already had to include a few other commits because the v3 branch was basically unmaintained since the last release. This is a decision for the project owners.

@msaecker
Copy link

The PR was merged and version 3.7.7 was released with python 3.12 wheels: https://github.com/uber/h3-py/releases/tag/v3.7.7

@ajfriend
Copy link
Contributor

@josteinl, have you tried the v4 beta on 3.12 (pip install 'h3==4.0.0b4')?

@josteinl
Copy link
Author

@josteinl, have you tried the v4 beta on 3.12 (pip install 'h3==4.0.0b4')?

I'm affraid not, but thank you for your notice.

@ajfriend
Copy link
Contributor

OK. I'll close this for now then. Please let us know if you have any issues with 3.12 on either v3.7 or v4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants