Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exposing delegate observers. #89

Merged
merged 13 commits into from
Sep 22, 2017
Merged

Add support for exposing delegate observers. #89

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5864478
Make AutoDisposingSubscriber inherit from FlowableSubscriber
Sep 19, 2017
d3a5db4
Add api for observer delegate to AutoDisposingObserver
Sep 18, 2017
c8695bb
Add api for observer delegate to AutoDisposingCompletableObserver
Sep 18, 2017
1244851
Add api for observer delegate to AutoDisposingMaybeObserver
Sep 18, 2017
379f478
Add api for observer delegate to AutoDisposingSingleObserver
Sep 18, 2017
675e962
Add api for subscriber delegate to AutoDisposingSubscriber
Sep 18, 2017
8728454
Fix test styling
Sep 21, 2017
e3dd21a
Fix comments in each interface
Sep 22, 2017
c78dc63
Remove random character that shouldnt have been added
Sep 22, 2017
45e6c31
Replace isEqualTo asserts with isSameAs, which is technically more co…
Sep 22, 2017
7270758
Move test member AtomicReferences into the specific test
Sep 22, 2017
71f0154
Fix checkstyle
Sep 22, 2017
bda1040
Add comments and @Experimental annotation
Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion autodispose/src/main/java/com/uber/autodispose/observers/AutoDisposingSubscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.uber.autodispose.observers;

import io.reactivex.FlowableSubscriber;
import io.reactivex.disposables.Disposable;
import org.reactivestreams.Subscriber;
import org.reactivestreams.Subscription;
Expand All @@ -24,4 +25,4 @@
* A {@link Disposable} {@link Subscriber} that can automatically dispose itself. Interface here
* for type safety but enforcement is left to the implementation.
*/
public interface AutoDisposingSubscriber<T> extends Subscriber<T>, Subscription, Disposable {}
public interface AutoDisposingSubscriber<T> extends FlowableSubscriber<T>, Subscription, Disposable {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would be good to include a tidbit of the explanation you put in the PR description in this commit message