Add support for exposing delegate observers. #89

mswysocki · 2017-09-21T23:10:52Z

Resolves #78

This change updated AutoDisposingSubscriber implement FlowableSubscriber instead of Subscriber. We wanted to have more consistency with how the rest of the Observers are handled in RxJava. This change remains backward compatible because FlowableSubscriber still extends Subscriber.

This also exposes all the different implementations of Observer to allow for introspection to the delegate Observer. This will be particularly useful for ReactiveX/RxJava#5590.

CLAassistant · 2017-09-21T23:10:58Z

All committers have signed the CLA.

ZacSweers

Looking good! From a high level I think there's a few changes we should make that are across the observers:

Let's inline the {@link Observer} mentions in docs, it should read like a sentence since they are linkified inline. Make sure you link the correct observer as well (e.g. right now they all use Observer but there is a unique Observer for each type, like SingleObserver).
Let's add a comment to the docs that explicitly call out that this API will change once the LambdaIntrospection stuff is out of @Experimental in RxJava (at which point we'll update it to return that interface instead and mark it nullable to return null upon non conforming types).
Let's add @Experimental to all the methods to indicate their plans to change. Borrow the RxJava annotation.
Let's make the atomic references in tests local to their specific unit tests rather than fields since they're only used in those methods.
Use reference comparison for the delegate observer in tests, not isEqualTo (which checks equality and isn't what we want).

ZacSweers · 2017-09-21T23:13:04Z

autodispose/src/main/java/com/uber/autodispose/observers/AutoDisposingSubscriber.java

@@ -24,4 +25,4 @@
 * A {@link Disposable} {@link Subscriber} that can automatically dispose itself. Interface here
 * for type safety but enforcement is left to the implementation.
 */
-public interface AutoDisposingSubscriber<T> extends Subscriber<T>, Subscription, Disposable {}
+public interface AutoDisposingSubscriber<T> extends FlowableSubscriber<T>, Subscription, Disposable {}


Nit: would be good to include a tidbit of the explanation you put in the PR description in this commit message

ZacSweers · 2017-09-21T23:14:26Z

autodispose/src/main/java/com/uber/autodispose/observers/AutoDisposingObserver.java

+public interface AutoDisposingObserver<T> extends Observer<T>, Disposable {
+
+    /**
+     * @return {@link Observer} The delegate Observer that is used under the hood for introspection purposes.


Nit: Did you mean to link the Observer here rather than inline?

I'd expect this to be like @return The delegate {@link Observer} that is used under the hood for introspection purposes.

ZacSweers · 2017-09-21T23:14:48Z

autodispose/src/test/java/com/uber/autodispose/AutoDisposeObserverTest.java

+      assertThat(atomicAutoDisposingObserver.get()).isInstanceOf(AutoDisposingObserver.class);
+      assertThat(((AutoDisposingObserver)atomicAutoDisposingObserver.get()).delegateObserver()).isNotNull();
+      assertThat(((AutoDisposingObserver)atomicAutoDisposingObserver.get()).delegateObserver())
+              .isEqualTo(atomicObserver.get());


This should be a reference check, not equality

ZacSweers · 2017-09-21T23:15:48Z

autodispose/src/test/java/com/uber/autodispose/AutoDisposeObserverTest.java

 import org.junit.After;
 import org.junit.Test;

 import static com.google.common.truth.Truth.assertThat;

 public class AutoDisposeObserverTest {

+  private final AtomicReference<Observer> atomicObserver = new AtomicReference();


since these are only used in one test, let's make them final local variables in those methods instead

ZacSweers · 2017-09-21T23:15:54Z

autodispose/src/test/java/com/uber/autodispose/AutoDisposeObserverTest.java

@@ -154,7 +162,7 @@
    lifecycle.onNext(1);
    source.onNext(2);

-    assertThat(source.hasObservers()).isTrue();
+    assertThat(source.hasObservers()).isTrue();Å


I believe this was from you trying to use my keyboard.

…rrect

mswysocki · 2017-09-22T22:37:55Z

Let's inline the {@link Observer} mentions in docs, it should read like a sentence since they are linkified inline. Make sure you link the correct observer as well (e.g. right now they all use Observer but there is a unique Observer for each type, like SingleObserver).

e3dd21a

Let's add a comment to the docs that explicitly call out that this API will change once the LambdaIntrospection stuff is out of @experimental in RxJava (at which point we'll update it to return that interface instead and mark it nullable to return null upon non conforming types).

bda1040

Let's add @experimental to all the methods to indicate their plans to change. Borrow the RxJava annotation.

bda1040

Let's make the atomic references in tests local to their specific unit tests rather than fields since they're only used in those methods.

7270758

Use reference comparison for the delegate observer in tests, not isEqualTo (which checks equality and isn't what we want).

45e6c31

ZacSweers

Woo!

Matt Wysocki added 7 commits September 21, 2017 15:56

Make AutoDisposingSubscriber inherit from FlowableSubscriber

5864478

Add api for observer delegate to AutoDisposingObserver

d3a5db4

Add api for observer delegate to AutoDisposingCompletableObserver

c8695bb

Add api for observer delegate to AutoDisposingMaybeObserver

1244851

Add api for observer delegate to AutoDisposingSingleObserver

379f478

Add api for subscriber delegate to AutoDisposingSubscriber

675e962

Fix test styling

8728454

mswysocki added the Enhancement label Sep 21, 2017

mswysocki added this to the 0.3.0 milestone Sep 21, 2017

mswysocki self-assigned this Sep 21, 2017

mswysocki requested a review from ZacSweers September 21, 2017 23:10

ZacSweers requested changes Sep 21, 2017

View reviewed changes

Matt Wysocki added 6 commits September 22, 2017 12:58

Fix comments in each interface

e3dd21a

Remove random character that shouldnt have been added

c78dc63

Replace isEqualTo asserts with isSameAs, which is technically more co…

45e6c31

…rrect

Move test member AtomicReferences into the specific test

7270758

Fix checkstyle

71f0154

Add comments and @experimental annotation

bda1040

ZacSweers approved these changes Sep 22, 2017

View reviewed changes

ZacSweers merged commit 5af3987 into uber:master Sep 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for exposing delegate observers. #89

Add support for exposing delegate observers. #89

mswysocki commented Sep 21, 2017

CLAassistant commented Sep 21, 2017 •

edited

Loading

ZacSweers left a comment

ZacSweers Sep 21, 2017

ZacSweers Sep 21, 2017

ZacSweers Sep 21, 2017 •

edited

Loading

ZacSweers Sep 21, 2017

ZacSweers Sep 21, 2017

mswysocki Sep 22, 2017

mswysocki commented Sep 22, 2017 •

edited by ZacSweers

Loading

ZacSweers left a comment

Add support for exposing delegate observers. #89

Add support for exposing delegate observers. #89

Conversation

mswysocki commented Sep 21, 2017

CLAassistant commented Sep 21, 2017 • edited Loading

ZacSweers left a comment

Choose a reason for hiding this comment

ZacSweers Sep 21, 2017

Choose a reason for hiding this comment

ZacSweers Sep 21, 2017

Choose a reason for hiding this comment

ZacSweers Sep 21, 2017 • edited Loading

Choose a reason for hiding this comment

ZacSweers Sep 21, 2017

Choose a reason for hiding this comment

ZacSweers Sep 21, 2017

Choose a reason for hiding this comment

mswysocki Sep 22, 2017

Choose a reason for hiding this comment

mswysocki commented Sep 22, 2017 • edited by ZacSweers Loading

ZacSweers left a comment

Choose a reason for hiding this comment

CLAassistant commented Sep 21, 2017 •

edited

Loading

ZacSweers Sep 21, 2017 •

edited

Loading

mswysocki commented Sep 22, 2017 •

edited by ZacSweers

Loading