Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

mattdrayer/WL-353: Add I18N Support #81

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

mattdrayer
Copy link

@xcompass @richardtape @asadiqbal08 --

After jumping through some hoops with the core XBlock project, I have made an update for Issue #79 and we can close PR #80 after this branch has been merged. Fingers crossed for a green build on the first shot 😄

Summary: It is now possible to ship translation sets for individual XBlocks. Documentation on this process can be found at http://edx.readthedocs.org/projects/xblock-tutorial/en/latest/edx_platform/edx_lms.html#internationalization-support

@mattdrayer mattdrayer force-pushed the mattdrayer/WL-353 branch 3 times, most recently from b848a66 to 6d8dda3 Compare March 28, 2016 18:32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 98.636% when pulling d33048a on mattdrayer:mattdrayer/WL-353 into 9865562 on ubc:master.

@mattdrayer
Copy link
Author

Well, I absolutely jinxed myself by hoping for a single pass, but we have a green build now, which means we are ready for a review by @richardtape and/or @xcompass. Would it be possible for one (or both) of you to take a look?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 98.636% when pulling d33048a on mattdrayer:mattdrayer/WL-353 into 9865562 on ubc:master.

@xcompass xcompass merged commit da0240c into ubc:master Mar 30, 2016
@xcompass
Copy link
Member

Sorry closed wrong PR. Looks good to me and tests are passed. I'll merge it. Thanks @mattdrayer and @asadiqbal08!

@mattdrayer
Copy link
Author

Excellent, thanks very much @xcompass!!!

@mattdrayer
Copy link
Author

Also with the merge complete we can now create the 0.5.2 release tag at your convenience. When it is available @asadiqbal08 or I will update the edx-platform project to reflect the update.

@xcompass
Copy link
Member

xcompass commented Apr 1, 2016

@mattdrayer @asadiqbal08 sorry for the delay. 0.5.2 is released and available on pypi as well. You can just update the version in edx platform requirement file. Let me know if you want me to send a PR. I would be happy to do it as well.

@asadiqbal08
Copy link

@xcompass Thanks. I just created a PR
Kindly take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants