Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

i18n support for peer instruction tool #79

Closed
asadiqbal08 opened this issue Mar 16, 2016 · 3 comments
Closed

i18n support for peer instruction tool #79

asadiqbal08 opened this issue Mar 16, 2016 · 3 comments
Assignees
Milestone

Comments

@asadiqbal08
Copy link

Need to mark all possible strings for translation in Peer Instruction tool and mark them for translations using runtime service.
We had made some changes against a ticket WL-315 in edx-platform to support the issue.

@richardtape richardtape self-assigned this Mar 16, 2016
@richardtape richardtape added this to the 0.6 milestone Mar 16, 2016
@richardtape
Copy link
Member

Hey @asadiqbal08

Thanks so much for the issue and the PR. We have an issue open for i18n support so it's definitely been on our radar. We've been tracking the issue you linked before moving on this as it was apparent that positive changes were happening. We'll review your PR and get back to you. I'll close the other issue as we can converse in here.

It looks like the unit tests failed in your PR. We can take a look at those if you don't get the time.

@mattdrayer
Copy link

Hi @richardtape! Thanks much for jumping on this one so quickly -- we have a pending change in the XBlock core repo that will probably merge tomorrow, and it should help to address the unit test failure. We'll keep you posted!

@mattdrayer
Copy link

This PR has been replaced by an updated change set found in #81. I am going to close this PR now to avoid confusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants