Apostrophe should not always cause step to return CharClass::InWord #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ", ”, «, and other such characters, an apostrophe can mark a quotation, in which case the character after it may need to be upper case. Before this commit, Hayagriva always considered the character after an apostrophe to be within a word, and therefore lowercased it. Closes typst#196
sandbergja
force-pushed
the
i196-initial-apostrophe
branch
from
c90a445 to
4ca7009
Compare
|
Rebased this so that hopefully CI passes. :-) |
|
This seems legitimate to me. Thanks! |
danilasar
pushed a commit
to danilasar/hayagriva
that referenced
this pull request
Dec 31, 2024
…ypst#244) Similar to ", ”, «, and other such characters, an apostrophe can mark a quotation, in which case the character after it may need to be upper case. Before this commit, Hayagriva always considered the character after an apostrophe to be within a word, and therefore lowercased it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
",”,«, and other such characters, an apostrophe can mark a quotation, in which case the character after it may need to be upper case. Before this commit, Hayagriva always considered the character after an apostrophe to be within a word, and therefore lowercased it.Closes #196