Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@Citation makes word following ' lowercase in escaped Hayagriva entry #196

Closed
1 task done
HawksDarris opened this issue Aug 2, 2024 · 0 comments · Fixed by #244
Closed
1 task done

@Citation makes word following ' lowercase in escaped Hayagriva entry #196

HawksDarris opened this issue Aug 2, 2024 · 0 comments · Fixed by #244
Labels
bug Something isn't working

Comments

@HawksDarris
Copy link

HawksDarris commented Aug 2, 2024 •
edited
Loading

Description

Hayagriva entry:

ukraine: 
  type: video
  title: "'Russia Is Not Going To Lose The War': JD Vance Blasts Senate Voting To Send Funding To Ukraine"
  date: 2024-02-14
  url: 
    value: https://www.youtube.com/watch?v=W53wILyEyEc
    date: 2024-08-02

document.typ:

Blah blah blah @ukraine

Expected result: The title should appear as 'Russia Is Not Going To Lose The War': JD Vance Blasts Senate Voting To Send Funding To Ukraine

Result (regardless of citation style): The title appears as 'russia Is Not Going To Lose The War': JD Vance Blasts Senate Voting To Send Funding To Ukraine

Note: With some experimentation, I have learned that this happens regardless of where the ' is. Any character following ' is lowercase.

Reproduction URL

No response

Operating system

Linux

Typst version

  • I am using the latest version of Typst
@HawksDarris HawksDarris added the bug Something isn't working label Aug 2, 2024
@HawksDarris HawksDarris changed the title @Citation makes first word of title lowercase in escaped Hayagriva entry @Citation makes word following ' lowercase in escaped Hayagriva entry Aug 3, 2024
@laurmaedje laurmaedje transferred this issue from typst/typst Aug 5, 2024
sandbergja added a commit to sandbergja/hayagriva that referenced this issue Oct 27, 2024
@sandbergja
Apostrophe should not always cause step to return CharClass::InWord
c90a445 
Similar to ", ”, «, and other such characters, an apostrophe can mark
a quotation, in which case the character after it may need to be
upper case. Before this commit, Hayagriva always considered the character
after an apostrophe to be within a word, and therefore lowercased it.

Closes typst#196
@sandbergja sandbergja mentioned this issue Oct 27, 2024
Merged
sandbergja added a commit to sandbergja/hayagriva that referenced this issue Nov 20, 2024
@sandbergja
Apostrophe should not always cause step to return CharClass::InWord
4ca7009 
Similar to ", ”, «, and other such characters, an apostrophe can mark
a quotation, in which case the character after it may need to be
upper case. Before this commit, Hayagriva always considered the character
after an apostrophe to be within a word, and therefore lowercased it.

Closes typst#196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apostrophe should not always cause step to return CharClass::InWord sandbergja/hayagriva
1 participant
@HawksDarris