Fix #142 #145
Merged
Fix #142 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
typst/citationberg#142 is merged, so you can Edit: Change the dep to a Git dependency instead so it can be used in Typst, patches are ignored by upstream dependents. |
|
Thank you! |
|
is this in any release typst version? I'm running into this problem but I cannot get this to actually use a single page... |
|
This will land in Typst 0.12 for which we expect a preview version this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #142.
Page ranges are now
RangeInclusive<i32>, which fits the semantics of a page range better. Also changes how single pages are turned to ranges:4now becomes the inclusive range4..=4, which fits.Also, in citationberg, ranges where start and end are the same only render start.
Depends on typst/citationberg#12.
This is just a quick fix until I find time to rework page ranges.