Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional page gets displayed when only one is specified in the bibliography entry #142

Closed
xkevio opened this issue Mar 19, 2024 · 11 comments · Fixed by #145
Closed

Additional page gets displayed when only one is specified in the bibliography entry #142

xkevio opened this issue Mar 19, 2024 · 11 comments · Fixed by #145

Comments

@xkevio
Copy link
Contributor

xkevio commented Mar 19, 2024

Since #104, I believe, single page numbers in the pages field (.bib) or in the page-range field (.yml) no longer render correctly. It always adds the following page as well, turning p. 103, for example, into p. 103 -- 104. Note that, whatever the CSL style uses as a word for page does not get pluralized.

This can be reproduced with just about any simple entry and many styles, like the default IEEE.
https://typst.app/project/rxfSNvq9A61PlAievgf9sa

@xkevio
Copy link
Contributor Author

xkevio commented Mar 20, 2024

@Drodt / @DerDrodt, maybe you know what caused this since you worked on the recent page range commits.

@DerDrodt
Copy link
Contributor

Yes, I have a quick fix in #145.

reknih pushed a commit that referenced this issue Apr 16, 2024
@MangoIV
Copy link

MangoIV commented Sep 30, 2024

this problem persists at least when rendering MLA9. e.g.
page-range: 33 gets rendered as p. 33-34

@xkevio
Copy link
Contributor Author

xkevio commented Sep 30, 2024

this problem persists at least when rendering MLA9. e.g. page-range: 33 gets rendered as p. 33-34

Are you rendering with just hayagriva and if so, main commit version or v0.5.3? Or with Typst?

@MangoIV
Copy link

MangoIV commented Sep 30, 2024

I have tried with both typst cloud and standalone typst 0.11.1. I have check typst, it should have had the patch in the last release.

@MangoIV
Copy link

MangoIV commented Sep 30, 2024

I would also be happy about a hacky fix for the moment :P

@xkevio
Copy link
Contributor Author

xkevio commented Sep 30, 2024

I assume by typst cloud you mean the webapp? Then both are currently on v0.11.1 and that version — trust me, I've checked — did not include this bugfix in particular (cc: @laurmaedje, you mentioned there was some reason for it)

@MangoIV
Copy link

MangoIV commented Sep 30, 2024

I see ~ maybe they didn't bump "citationberg"? :P

@MangoIV
Copy link

MangoIV commented Sep 30, 2024

I'll see if I can quickly ™️ build from source.

@xkevio
Copy link
Contributor Author

xkevio commented Sep 30, 2024

I'll see if I can quickly ™️ build from source.

Not sure if hayagriva was bumped yet on typst main (Cargo.toml says its still 0.5.3 which doesnt have the fix). I assume the dependencies will be bumped soon as we get closer to v0.12. You can however still build from source, you just have to point the hayagriva entry in the Cargo.toml to this repository.

@MangoIV
Copy link

MangoIV commented Sep 30, 2024

building from source worked just fine. thank you <3

danilasar pushed a commit to danilasar/hayagriva that referenced this issue Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants