Ported the start here example from 0.8 #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I created a tut doc for the example, though I didn't know where to include that in the guide, so it is standalone for now. - I changed the signature of utf8Encode and utf8Decode -- both were working with Chunk[Byte] instead of Byte which made using them with the io package annoying. The original signatures are available under a `C` suffix -- `utf8EncodeC` and `utf8DecodeC`. The implementations did not exploit the chunky nature in any way, except for the handling of encoding/decoding empty strings -- `utf8EncodeC andThen utf8DecodeC == id` for all strings, whereas `utf8Encode andThen utf8Decode == id` for all non-empty strings. - Added a new text.lines pipe, which buffers a stream of strings and emits individual lines.
mpilquist
force-pushed
the
topic/start-here
branch
from
6809ddf to
c39fa96
Compare
|
Cool. There was no good reason for signature of those text transducers, it was just an oversight. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf8Encodeandutf8Decode-- both were working withChunk[Byte]instead ofBytewhich made using them with the io package annoying. The original signatures are available under aCsuffix --utf8EncodeCandutf8DecodeC. The implementations did not exploit the chunky nature in any way, except for the handling of encoding/decoding empty strings --utf8EncodeC andThen utf8DecodeC == idfor all strings, whereasutf8Encode andThen utf8Decode == idfor all non-empty strings. I believe this is due to the fact that we don't emit empty chunks in the interpreter.