-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base64 text pipe #1587
Comments
I'd love to be able to reuse the methods on |
@ChristopherDavenport How are these signatures for the object text {
def base64Decode[F[_]]: Pipe[F, String, Byte] =
_.through(base64DecodeC).flatMap(Stream.chunk)
def base64DecodeC[F[_]]: Pipe[F, String, Chunk[Byte]] = ???
def base64Encode[F[_]]: Pipe[F, Byte, String] =
_.chunks.through(base64EncodeC)
def base64EncodeC[F[_]]: Pipe[F, Chunk[Byte], String] = ???
} I think we can skip the chunk variants assuming they stay identities. |
Is there a reason to have the separate chunk variants at all rather than just ensuring that the primary variants operate on chunks rather than individual bytes? |
@djspiewak I think we can skip the chunk variants. I looked up why we have the utf8 chunk variants and found this: #609 |
Ah interesting. It's worth noting that it would probably be more efficient, even in the Either way, we definitely don't need the |
I was interested recently in a large file contents and translating it from its base64 to the string representation.
I think it would be fairly straightforward to implement but wanted to see if there was an interest.
The text was updated successfully, but these errors were encountered: