Specs2 var Optimization #609
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm semi-impartial either way. This isn't a contended var, so we don't have to reason about atomicity across multiple writes, meaning this is a code organization thing. It was more clear to me as multiple vars, but if it's more clear to anyone else as a single var, then let's go for it! |
|
This was something @armanbilge requested. @armanbilge what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, which really starts at dccb2b8, addresses a comment @armanbilge made in #608. I thought it best to move that conversation to a separate PR because I'm not entirely sure why this code was originally implemented with three
vars when I think even originally it could have been one.