Tweak Specs2 CatsResource to rethrow exceptions raised during resource acquisition #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpholt
force-pushed
the
resource-acquisition-exception
branch
from
8e59882 to
8ce3b4f
Compare
bpholt
commented
Nov 20, 2024
specs2/shared/src/test/scala/cats/effect/testing/specs2/CatsResourceErrorSpecs.scala
Show resolved
Hide resolved
When using CatsResource with Specs2, if the resource acquisition raises an exception, the tests will never start and the exception will never be reported.
…ource acquisition
bpholt
force-pushed
the
resource-acquisition-exception
branch
from
8ce3b4f to
4a70db2
Compare
armanbilge
reviewed
Nov 21, 2024
specs2/shared/src/main/scala/cats/effect/testing/specs2/CatsResource.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if an exception is raised when acquiring the
val resource: Resource[F, A], it would previously be swallowed by the Future launched bybeforeAll. Due to the exception, the gate is never closed (i.e., theDeferredis never completed), so theDeferred#getcall inwithResourcenever completes.This PR puts a timeout on the
Deferred#getcall inwithResourceto avoid waiting forever. It also updatesvar valueto maybe containEither[Throwable, A], so that the exception raised in the acquisition phase is raised in the test, so that the user can see the details of the exception and hopefully resolve the underlying issue.