Fix data in generated pom.xml #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikalpribadi
approved these changes
Oct 4, 2019
dmitrii-ubskii
pushed a commit
that referenced
this pull request
Aug 25, 2023
Remove `Answer.explanations()` shortcut method that always returned empty set and is not documented and inconsistent with other APIs!
dmitrii-ubskii
pushed a commit
to dmitrii-ubskii/typedb-driver
that referenced
this pull request
Aug 31, 2023
## What is the goal of this PR? Our fork of `rules-nodejs` is ~600 commits behind the official upstream repo and it's time to switch to upstream rules so it's easier to keep up. ## What are the changes implemented in this PR? * Migrate `nodejs_jest_test` to `jasmine_node_test` * `it()` instead of `test()` in test definitions * `expect(obj).toHaveLength(len)` is not available in Jasmine, so we use `expect(obj.length).toBe(len)`. This corresponds to exact [definition](https://jestjs.io/docs/en/expect.html#tohavelengthnumber) of what original function does. * `xit()` instead of `test.skip()` * `jasmine.DEFAULT_TIMEOUT_INTERVAL` instead of `jest.setTimeout` * `await expectAsync(promise).toBeRejected();` instead of `await expect(promise).rejects.toThrowError();` * Use `yarn` to install dependencies instead of `npm`: * this is a currently-recommended way by `rules-nodejs` (see their `README`) * `grpc` failed to install with `npm_install` — planning to open an issue soon * Add `node_modules` to `.gitignore` — `rules-nodejs` now install Node deps right into workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Fix #26
Specify fields needed for Maven Central deployment
What are the changes implemented in this PR?
Specify
project_name,project_description,project_urlandscm_url