Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The pom.xml generated by 'bazel build //:assemble-maven' contains missing info #26

Closed
lolski opened this issue Jul 18, 2019 · 0 comments · Fixed by #48
Closed

The pom.xml generated by 'bazel build //:assemble-maven' contains missing info #26

lolski opened this issue Jul 18, 2019 · 0 comments · Fixed by #48
Assignees
@vmax
Labels
status: solved type: bug

Comments

@lolski
Copy link
Member

lolski commented Jul 18, 2019 •
edited
Loading

Description

The pom.xml generated during Maven assembly or deployment contains missing information.

Environment

  1. OS (where Grakn server runs): N/A
  2. Grakn version (and platform): N/A
  3. Other environment details:

Reproducible Steps

$ bazel build //:assemble-maven
$ cat bazel-bin/pom.xml

Expected Output

<scm>
<connection>http://github.com/graknlabs/client-java</connection>
<developerConnection>http://github.com/graknlabs/client-java</developerConnection>
<tag>1.5.3</tag>
<url>http://github.com/graknlabs/client-java</url>
</scm>

Actual Output

<scm>
<connection>PROJECT_URL</connection>
<developerConnection>PROJECT_URL</developerConnection>
<tag>1.5.3</tag>
<url>PROJECT_URL</url>
</scm>

Additional information
@lolski lolski self-assigned this Jul 18, 2019
@vmax vmax assigned vmax and unassigned lolski Oct 4, 2019
@vmax vmax mentioned this issue Oct 4, 2019
Merged
haikalpribadi pushed a commit that referenced this issue Oct 4, 2019
@vmax @haikalpribadi
Fix data in generated pom.xml (#48)
8d141c0 
## What is the goal of this PR?

Fix #26
Specify fields needed for Maven Central deployment

## What are the changes implemented in this PR?

Specify `project_name`, `project_description`, `project_url` and `scm_url`
dmitrii-ubskii added a commit to dmitrii-ubskii/typedb-driver that referenced this issue Jul 13, 2023
@dmitrii-ubskii
Check formatting in CI (typedb#26)
11dbed3 
## What is the goal of this PR?

We add a check to the Factory CI configuration that ensures that all
Rust code has been formatted properly.

## What are the changes implemented in this PR?

We add rustfmt configuration, reformat the project, and ensure that
rustfmt had been run in CI.

Closes typedb#10.
dmitrii-ubskii pushed a commit that referenced this issue Aug 25, 2023
@vmax
Fix dependency on enum34 (#26)
badf096 
## What is the goal of this PR?

Fix `client-python` on 3.4+

## What are the changes implemented in this PR?

`enum34` is incompatible with Python 3.4+. Instead, we replace it with `enum-compat` which a no-op on incompatible versions
dmitrii-ubskii pushed a commit to dmitrii-ubskii/typedb-driver that referenced this issue Aug 31, 2023
@flyingsilverfin
Finalize test deployment (typedb#26)
ee11ed7 
Upgrade CircleCI node version, fix nodejs test deployment bugs, and test increase timeout to 15sec  per test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmax vmax

Labels
status: solved type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix data in generated pom.xml typedb/typedb-driver
3 participants
@lolski @vmax @grabl