Introduce @glint-ignore and @glint-expect-error directives
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TypeScript, it's possible to tell the typechecker to either silence any errors that begin on a particular line (
@ts-ignore) or to specifically expect an error and fail if none is produced (@ts-expect-error). While it's generally preferable to have code that typechecks correctly, these tools are useful to have available for cases where expressiveness of the type system falls short.This PR introduces equivalent directives for Glint. Unfortunately we can't directly rely on the TS implementation of these, as there's no one-to-one mapping between lines in the input template and lines in our translated TypeScript.
Closes #82