Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Ignore lines in HBS with {{! glint-ignore }} or something #82

Closed
boris-petrov opened this issue Mar 29, 2021 · 1 comment · Fixed by #166
Closed

[Feature request] Ignore lines in HBS with {{! glint-ignore }} or something #82

boris-petrov opened this issue Mar 29, 2021 · 1 comment · Fixed by #166
Labels
enhancement New feature or request

Comments

@boris-petrov
Copy link
Contributor

Ability to ignore lines in HBS would be great.

@dfreeman
Copy link
Member

We've punted on this so far because figuring out the right mapping is a bit thorny. Since // @ts-ignore operates on a line-by-line basis, and HBS lines don't necessarily map 1:1 to the emitted TS, we need to be a little bit thoughtful about what we emit in this scenario to avoid either making it impossible to ignore certain things or accidentally squashing too much instead.

That's not to say having a @ts-ignore (and/or maybe preferably @ts-expect-error) equivalent isn't valuable, though—it's definitely on the radar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants