Merge Azure/sonic-buildimage #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Volodymyr Samotiy <[email protected]>
…ices (#2634) * [services] Ensure swss and syncd services start before dependent services * Add 'attach' functions to scripts which get installed to /usr/local/bin so that services only reference the one script each * Add 'After=swss.service' to syncd.service
…aces to be ready before starting radvd (#2558)
Signed-off-by: Nazarii Hnydyn <[email protected]>
Rate limiting at 20,000 messages per 5-minute interval
start() is called by service startPre method, which is blocking. Starting syncd service here is causing deadlock. attach() is called by service start method, which is non-blocking. Signed-off-by: Ying Xie <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
DaemonBase is to wrap the common function of daemons, such as logging, signal handling, db connector, load specific platform plugins. Signed-off-by: Kevin Wang <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
* Fix issue with platform file path name * BFN SDE update
Signed-off-by: Volodymyr Samotiy <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
…2659) Signed-off-by: Qi Luo <[email protected]>
Lossy traffic does not need to be mapped to different ingress PGs. They can all share the same ingress PG. Signed-off-by: Wenda Ni <[email protected]>
…ead of 'docker attach' (#2661)
…for internal purposes (#2631) - Why it is required since SONiC master switches ifupdown package to the new implementation (ifupdown2), it is required to change the configuration of a platform-specific interface for wedge100bf_32x and wedge100bf_65x platforms (bc of ifupdown2 doesn't support auto mode for inet6 protocol). Also, need to make some refactoring and remove if platform == smth then.. from the system level scripts. - What I did removed customization of /usr/bin/interfaces-config.sh explicitly created directory /etc/network/interfaces.d added "source" to the /etc/network/interfaces generation template (to include platform-specific interfaces processing) added platform-specific interfaces config itself (for wedge100bf_32x and wedge100bf_65x) fixed testcase in sonic-config-engine - How to verify it build image for wedge100bf_32x perform sudo config reload -y on new installation check the correct configuration of usb0 interface - Description for the changelog Allow configuration of platform-specific interfaces
* [dockers] Upgrade Mellanox syncd docker to stretch Signed-off-by: Stepan Blyschak <[email protected]>
MLNX_SDK_VERSION = 4.3.0136 SPC_FW_VERSION = 13.1910.0920 MLNX_SAI_VERSION = SAIRel1.13.7-master Signed-off-by: Andriy Moroz <[email protected]>
…ipaddress has backport to python2.7
[devices] add new accton platform minipack. Add support for new platform, minipack. It has CPU: Broadwell DE – D1527 MAC: Tomahawk3(BCM56980). PHY:Broadcom BCM81724, 4 pcs, Gearbox for PIM-16Q BMC:AST2520 8 hot-swappable Port-Interface-Modules, each of them has 16*100G QSFP. - What I did Add device and platform files for minipack. - How I did it Add as SONiC Porting Guide. - How to verify it decode-syseeprom sensors psuutil sfputil thermal monitor bcmsh on port status (port LEDs may not working)
…in separated mode (#2961) In separated mode, frr requires to run vtysh_b to load individual configuration Signed-off-by: Guohan Lu <[email protected]>
…/power on some cables (#2957) * [device/mellanox/x86_64-mlnx_msn2700-r0/plugins/sfputil.py] purpose and restrictions 1. reading eeprom via ethtool. 2. avoid changing common codes shared by all the manufacture (sonic-platform-common), contrain all the modifications with Mellanox-specific code. current implementation A new class based on SfpUtilBase and a new method _read_eeprom_specific_bytes_via_ethtool have been introduced in order to change the way the eprom DOM data is read. Typically the best practice to do this kind of thing is to contrain the modification within the function which execute reading operations only and keep other stuffs (especially the interface) untouched. However, this can hardly be achieved since the original reading function takes the file object as input parameter to represent the port. It is done by having the file object to point to /var/run/hwmanagement files, which will not be maintained in the future. As a result, a new interface has to be introduced with a port number/name as input parameter in order to get rid of the dependency on the those files: _read_eeprom_specific_bytes_via_ethtool Since the interface changed, all methods that call the interface should also be overwritten in order to call the new interface, including: _read_eeprom_devid get_transceiver_info_dict get_transceiver_dom_info_dict Only interface used to read eeprom DOM has been replaced and the main logic has not been changed except the following mentioned. 1. reading DOM data for sfp port, which is implementioned in get_transceiver_dom_info_dict. In this case a "calibration" should be firstly read from eeprom before other values like temperature, voltage, rx/tx power, can be parsed. However, this has been ignored in the original code, resulting in that the data cann't be parsed. 2. In the original implemention the data area containing the data are read from DOM separatedly in order to avoid read uncessary data and achieve a better performance. Having used ethtool to read DOM data, the performance gap between reading all the area and reading the spot data separatedly has been narrowed to almost zero. To make the code neat and readable, we change the way to read this data. * [sfputil] Returns dict with all data set to N/A for ports without dom support Currently, the way in which dom data is read has been changed from using sysfs to using ethtool. The ethtool returns None for ports without dom support, resulting in None being returned. However, this fails xcvrd to add the TRANSCEIVER_DOM_SENSOR table entry of associated port to CONFIG_DB and then causes SNMP fail. To address this issue a default dict is initialized with all data set to 'N/A' and is returned is the above case. BTW, in the original implementation which sysfs is used to read dom data, even though non-None data is returned for ports without dom support, it does not contain valid data. This can result in wrong data in TRANSCEIVER_DOM_SENSOR table. * [sfputil] removing unnecessary empty lines removing redundent code replacing hardcoding strings/numbers with predefined const variables
…er(s) on another (#2946)
Signed-off-by: yorke <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
* expose SDK share buffer and unix socket from syncd * fix PR comments * fix community comments and add TODO
Disabling i2c function of ir3507a which may failed i2c tranfer to others. Signed-off-by: roy_lee <[email protected]>
* Add updateHostName function to docker_image_ctl.j2 * Add hostname specification on container creating step * Add listener for hostname changes in hostcfgd Signed-off-by: Myron Sosyak <[email protected]>
* Add port configuration for HWSKU Arista-7060PX4-O32 * Add 64x100G configuration for 7060PX4-32
* [sfputil]Remove the dependency on sysfs for sfputil, mainly get_presence and port_to_eeprom_mapping Remove the dependency on sysfs, including: 1. rewrite get_presence by using ethtool; 2. remove interface port_to_eeprom_mapping which is no longer referenced; 3. remove code that references port_to_eeprom_mapping and _port_to_eeprom_mapping; 4. remove private member qsfp_sysfs_path which is no longer referenced. * [sfputil.py] minor adjustment: move the presence=False to the beginning of get_presence.
* DellEmc-S6000 Backend work for lastreboot reason
Signed-off-by: brandon_chuang <[email protected]>
* Congregate plugin scripts for Arista platforms * Update arista driver submodules Pulls new platform API related changes
) Advancing sub module pointers to dynamic transceiver support feature commit. - src/sonic-swss f437f9f..d616764 [policerorch]: Add PolicerOrch to bundle with mirror session (889) Fix MIRROR_SESSION table macro name (802) Ignore neighbor entry with BCAST MAC, check SAI status exists (914) [vstest]: Update the mirror session state table name (917) [test]: Skip tests under investigation (919) [debian] increment debian compatibility to 10 to enable parallel package build (911) [aclorch]: Add MIRROR_DSCP table type (906) [test]: Mark some VLAN tests as Stretch only (903) [warm restart assist] assume vector values could be reordered (921) Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (869) Fix vlan incremental config and add vs test cases (799) Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (897) add dynamic transceiver tuning support (821) - src/sonic-platform-common 92b54b1..7f95a2a Enhance new platform API (19) Add .gitignore file (28) [sonic_platform_base] Add sonic_sfp and sonic_eeprom to sonic_platform_base (27) Added type abbrev name to be used in media_settings.json for Dynamictransceiver tuning (32) - src/sonic-platform-daemons c8931f3..366ac0e Fixed xcvrd shutdown flow. (23) Add .gitignore file (27) Dynamic transceiver tuning support (26)
Modifying media settings file according to latest design
…witch (BCM956960K) (#2682) These patches add support for the Broadcom XMC card (XLR/GTS). At this moment only Tomahawk switch (BCM956960K) is supported. Add device/broadcom/x86_64-bcm_xlr-r0 and platform/broadcom/sonic-platform-modules-brcm-xlr-gts files
…2848) * Generate default VRF table for router interfaces * Updated jinja2 template to have prefix filter
…f memory (#2988) - What I did Currently when the system is under memory pressure, the OOM killer kicks in and kills a rogue process. Killing a rogue process can cause the device to be un-healthy leading to blackholing of the traffic. To avoid this, configure the OOM to do a kernel panic which will cause the device to reboot and come back up healthy. - How I did it Added the sysctl variable panic_on_oom and set the value to 2. Setting it to 2 will ensure OOM killer to always do a kernel panic.
* [FRR]: Aligned configs for unified/separated modes. * Fixed IPv6 neighbors issue: #2986 Signed-off-by: Nazarii Hnydyn <[email protected]>
new FW/SDK limits pool size to 37M Signed-off-by: Stepan Blyschak <[email protected]>
… based dockers (#2833) * Updated Makefile infrastructure to build debug images. As a sample, platform/broadcom/docker-orchagent-brcm.mk is updated to add a docker-orchagent-brcm-dbg.gz target. Now "BLDENV=stretch make target/docker-orchagent-brcm-dbg.gz" will build the debug image. NOTE: If you don't specify NOSTRETcH=1, it implicitly calls "make stretch", which builds all stretch targets and that would include debug dockers too. This debug image can be used in any linux box to inspect core file. If your module's external dependency can be suitably mocked, you my even manually run it inside. "docker run -it --entrypoint=/bin/bash e47a8fb8ed38" You may map the core file path to this docker run. * Dropped the regular binary using DBG_PACKAGES and a small name change to help readability. * Tweaked the changes to retain the existing behavior w.r.t INSTALL_DEBUG_TOOLS=y. When this change ('building debug docker image transparently') is extended to all dockers, this flag would become redundant. Yet, there can be some test based use cases that rely on this flag. Until after all the dockers gets their debug images by default and we switch all use cases of this flag to use the newly built debug images, we need to maintain the existing behavior. * 1) slave.mk - Dropped unused Docker build args 2) Debug template builder: renamed build_dbg_j2.sh to build_debug_docker_j2.sh 3) Dropped insignifcant statement CMD from debug Docker file, as base docker has Entrypoint. * Reverted some changes, per review comments. "User, uid, guid, frr-uid & frr-guid" are required for all docker images, with exception of debug images. * Get in sync with the new update that filters out dockers to be built (SONIC_STRETCH_DOCKERS_FOR_INSTALLERS) and build debug-dockers only for those to be built and debug target is available. * Mkae a template for each target that can be shared by all platforms. Where needed a platform entry can override the template. This avoids duplication, hence easier to maintain. * A small change, that can fit better with other targets too. Just take the platform code and do the rest in template. * Extended debug to all stretch based docker images * 1) Combined all orchagent makefiles into one platform independent make under rules/docker-orchagent.mk 2) Extened debug image to all stretch dockers * Changes per review comments: 1) Dropped LIBSAIREDIS_DBG from database, teamd, router-advertiser, telemetry, and platform-monitor docker*.mk files from _DBG_DEPENDS list 2) W.r.t docker make for syncd, moved DEPENDS from template to specific makefile and let the template has stuff that is applicable to all. * 1) Corrected a copy/paste mistake * Fixed a copy/paste bug * The base syncd dockers follow a template, which defines the base docker as DOCKER_SYNCD_BASE instead of DOCKER_SYNCD_<platform code>. Fix the docker-syncd-<mlnx, bfn>.mk to use the new one. [Yet to be tested locally] * Fixed spelling mistake * Enable build of dbg-sonic-broadcom.bin, which uses dbg-dockers in place of regular dockers, for dockers that build debug version. For dockers that do not build debug version, it uses the regular docker. This debug bin is installable and usable in a DUT, just like a regular bin. * Per review comments: 1) Share a single rule for final image for normal & debug flavors (e.g. sonic-broadcom.bin & sonic-broadcom-dbg.bin) 2) Put dbg as suffix in final image name. 3) Compared target/sonic-broadcom.bin.logs with & w/o fix to verify integrity of sonic-broadcom.bin 4) Compared target/sonic-broadcom.bin.logs with sonic-broadcom-dbg.bin.log for verification This fix takes care of ONIE image only. The next PR will cover the rest. The next PR, will also make debug image conditional with flag. * Updated per comments. Now that debug dockers are available, do not need a way to install debug symbols in regular dockers. With this commit, when INSTALL_DEBUG_TOOLS=y is set, it builds debug dockers (for dockers that enable debug build) and the final image uses debug dockers. For dockers that do not enable debug build, regular dockers get used in the final image. Note: The debug dockers are explicitly named as <docker name>-dbg.gz. But there is no "-dbg" suffix for image. Hence if you make two runs with and w/o INSTALL_DEBUG_TOOLS=y, you have complete set of regular dockers + debug dockers. But the image gets overwritten. Hence if both regular & debug images are needed, make two runs, as one with INSTALL_DEBUG_TOOLS=y and one w/o. Make sure to copy/rename the final image, before making the second run.
Signed-off-by: brandon_chuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)