-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supervisor] Prevent crash if system clock rolls back within startsecs; Refactor patch #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Mar 4, 2019
Made to 201811 branch on 3/6/2019 |
yxieca
pushed a commit
that referenced
this pull request
Mar 7, 2019
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 10, 2019
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
The ntpd process will exit silently with "-x" startup option when the current system time is drifted too far from the ntp server's time (> 1000 seconds). The option was introduced to workaround the supervisord issue which was fixed: sonic-net#2624 We are reverting the change to use "-g" option for ntpd process: Revert "[ntp] disable ntp time jump (sonic-net#2589)" This reverts commit a57cb14. Signed-off-by: Zhenggen Xu <[email protected]> RB=2010953 G=lnos-reviewers R=pchaudhary,pmao,vapatil,samaity,zxu A=
yxieca
pushed a commit
that referenced
this pull request
Jan 31, 2023
5e84f2525 [202205][show] Add bgpraw to show run all (#2624)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
startsecs
. The crash would present itself with log messages similar to the following:Also refactored existing patch (to prevent supervisor from waiting an excessive amount of time if the system clock rolls backward) to match my simplified PR (with additional tests) which is open in the Supervisor repo ( [process.py] Handle scenario where system clock rolls backward Supervisor/supervisor#1047)
This PR should also pick cleanly into the 201803 branch.
- How to verify it
startsecs
set to a value > 0. Shortly afterstartsecs
elapses (which causes supervisor to place the process in the RUNNING state), roll the system clock backward by a value <=startsecs
. Then, within the amount of seconds you just rolled the clock back, cause the process to exit. Without this fix, at this point, supervisor will crash. With this fix, supervisor should recognize that the process was already in the RUNNING state and allow the process to exit without crashing.