my little proxy #202
Merged
my little proxy #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @author Doug Tangren | ||
| */ | ||
| trait Proxied[T] { |
There was a problem hiding this comment.
not sure it matters, but this could be covariant.
There was a problem hiding this comment.
yea. I was playing with some examples in the sbt console and that occurred to me but it didn't seem to buy me anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored proxy idea out of instrumented branch as its useful in many other context for store extensions. I put an example in the scala doc in the core module and defined proxy interfaces for {Readable,Writable,Mergeabl}Stores. I changed the names a bit from my other branch but I can update that branch after this gets reviewed.
The general idea is that there's a proxy implementation of
Proxied[T]defined for each core store typeT.Combinators and other custom functionality can now create a new
XXXProxyfor an instance ofXXXoverriding only what they need. All other method calls are automatically forwarded to the proxied instance