add onFailure to EnrichedMergeableStore #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,4 +49,17 @@ class EnrichedMergeableStore[K, V](store: MergeableStore[K, V]) { | |||
|
|
|||
| def convert[K1, V1](fn: K1 => K)(implicit bij: ImplicitBijection[V1, V]): MergeableStore[K1, V1] = | |||
| MergeableStore.convert(store)(fn) | |||
|
|
|||
| def onFailure(rescueException: Throwable => Unit): MergeableStore[K, V] = new MergeableStore[K, V] { | |||
There was a problem hiding this comment.
can we rename "onMergeFailure"+
|
Can you change this (should be less code) to use the proxy pattern in #202 ? |
|
for instance, close was not plumbed through here. |
|
yea. that's the reason it's useful. All delegation is handled for you so you don't forget things. Like closing a network connection cleanly! you could probably do def onMergeFailure(rescueException: Throwable => Unit): MergeableStore[K, V] =
new MergeableStoreProxy(store) {
override def merge(kv: (K, V)) = self.merge(kv).onFailure(rescueException)
override def multiMerge[K1 <: K](kvs: Map[K1, V]) =
self.multiMerge(kvs).mapValues { _.onFailure(rescueException) }
}shorter and safer |
|
@singhala ? Any update? Can we talk you into using the pattern above? |
|
ping |
|
Sorry I lost track of this while on vacation. Yes, I'll update this diff with the new pattern later today. |
johnynek
added a commit
that referenced
this pull request
Jan 13, 2014
add onFailure to EnrichedMergeableStore
| override def self = store | ||
| override def merge(kv: (K, V)) = store.merge(kv).onFailure(rescueException) | ||
| override def multiMerge[K1 <: K](kvs: Map[K1, V]) = | ||
| store.multiMerge(kvs).mapValues { _.onFailure(rescueException) } |
There was a problem hiding this comment.
mapValues is lazy. This is not being applied if any keys are not accessed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.