Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic for replicating writes and reads to stores #20

Merged
merged 6 commits into from
Feb 8, 2013
Merged

add logic for replicating writes and reads to stores #20

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7850ad3
add logic for replicating writes and reads to stores
singhala Feb 8, 2013
5b6839c
move to replicate fn
singhala Feb 8, 2013
5b2b92a
remove useless self
singhala Feb 8, 2013
cb8e4cd
switched to ReplicatedStore
singhala Feb 8, 2013
186852b
added ReplicatedStoreProperties
singhala Feb 8, 2013
621962a
added license info
singhala Feb 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storehaus-algebra/src/main/scala/com/twitter/storehaus/algebra/StoreAlgebra.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class AlgebraicStore[StoreType <: Store[StoreType, K, V], K, V](store: StoreType
* Store which aggregates values added with + into the existing value in the store.
* If addition ever results in a zero value, the key is deleted from the store.
*/
class AggregatingStore[StoreType <: Store[StoreType, K, V], K, V: Monoid](store: StoreType)
class AggregatingStore[StoreType <: Store[StoreType, K, V], K, V: Monoid](store: Store[StoreType, K, V])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? I'm surprised the StoreType alone isn't enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ashu, I bet this is because you had some apply method that returned Store[StoreType, K, V] instead of StoreType. Fix that up on your end and it'll work.

extends Store[AggregatingStore[StoreType, K, V], K, V] {
override def get(k: K) = store.get(k)
override def multiGet(ks: Set[K]) = store.multiGet(ks)
Expand Down
22 changes: 19 additions & 3 deletions storehaus-core/src/main/scala/com/twitter/storehaus/Store.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,28 @@ object Store {
}
})
}

/**
* Replicates writes to all stores, and takes the first successful read.
*/
def replicate[Self <: Store[Self, K, V], K, V](stores: Seq[Store[Self, K, V]]): Store[Self, K, V] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do this, the trait returns don't need to change:

import Store.{selectFirstSuccessfulTrial => selectFirst}

class ReplicatedStore[StoreType <: Store[StoreType, K, V], K, V](stores: Seq[StoreType])
: Store[ReplicatedStore[StoreType, K V], K, V] = {
  override def get(k: K) = selectFirst(stores.map { _.get(k) })
  override def multiGet(ks: Set[K]) = selectFirst(stores.map { _.multiGet(ks) })
  override def update(k: K)(fn: Option[V] => Option[V]) =
    Future.collect(stores.map { _.update(k)(fn) }).map { new ReplicatedStore(_) }
  override def -(k: K) =
    Future.collect(stores.map { _ - k }).map { new ReplicatedStore(_) }
  override def +(pair: (K,V)) =
    Future.collect(stores.map { _ + pair }).map { new ReplicatedStore(_) }
}

import Store.{selectFirstSuccessfulTrial => selectFirst}
new Store[Self, K, V] { combined =>
override def get(k: K) = selectFirst(stores.map { _.get(k) })
override def multiGet(ks: Set[K]) = selectFirst(stores.map { _.multiGet(ks) })
override def update(k: K)(fn: Option[V] => Option[V]) =
Future.collect(stores.map { _.update(k)(fn) }).map { _ => combined }
override def -(k: K) = Future.collect(stores.map { _ - k }).map { _ => combined }
override def +(pair: (K,V)) = Future.collect(stores.map { _ + pair }).map { _ => combined }
}
}

}

trait Store[Self <: Store[Self,K,V], K, V] extends ReadableStore[K, V] {
def -(k: K): Future[Self]
def +(pair: (K,V)): Future[Self]
def update(k: K)(fn: Option[V] => Option[V]): Future[Self] = {
def -(k: K): Future[Store[Self,K,V]]
def +(pair: (K,V)): Future[Store[Self,K,V]]
def update(k: K)(fn: Option[V] => Option[V]): Future[Store[Self,K,V]] = {
get(k) flatMap { opt: Option[V] =>
fn(opt)
.map { v => this + (k -> v) }
Expand Down