add logic for replicating writes and reads to stores #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Replicates writes to both stores, and uses the "or" logic defined on ReadableStore to replicate reads. | ||
| */ | ||
| def combinedWith(other: Store[Self, K, V]): Store[Self, K, V] = { |
There was a problem hiding this comment.
should we do this with a Seq[Store]?
There was a problem hiding this comment.
Add a combine method to the companion object that does this with a seq, then have this method call Store.combine(Seq(this, other))
| /** | ||
| * Replicates writes to all stores, and takes the first successful read. | ||
| */ | ||
| def replicate[Self <: Store[Self, K, V], K, V](stores: Seq[Store[Self, K, V]]): Store[Self, K, V] = { |
There was a problem hiding this comment.
If you do this, the trait returns don't need to change:
import Store.{selectFirstSuccessfulTrial => selectFirst}
class ReplicatedStore[StoreType <: Store[StoreType, K, V], K, V](stores: Seq[StoreType])
: Store[ReplicatedStore[StoreType, K V], K, V] = {
override def get(k: K) = selectFirst(stores.map { _.get(k) })
override def multiGet(ks: Set[K]) = selectFirst(stores.map { _.multiGet(ks) })
override def update(k: K)(fn: Option[V] => Option[V]) =
Future.collect(stores.map { _.update(k)(fn) }).map { new ReplicatedStore(_) }
override def -(k: K) =
Future.collect(stores.map { _ - k }).map { new ReplicatedStore(_) }
override def +(pair: (K,V)) =
Future.collect(stores.map { _ + pair }).map { new ReplicatedStore(_) }
}
sritchie
added a commit
that referenced
this pull request
Feb 8, 2013
add logic for replicating writes and reads to stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.