Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate friendlyName at 64 chars #133

Merged
merged 5 commits into from
Oct 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ twilio.env

### Backup package.json files created during release ###
*.bak
.idea/
7 changes: 6 additions & 1 deletion src/commands/profiles/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,13 @@ class ProfilesCreate extends BaseCommand {
}
}

getApiKeyFriendlyName() {
const friendlyName = `twilio-cli for ${os.userInfo().username} on ${os.hostname()}`;
return friendlyName.substring(0, 64);
}

async saveCredentials() {
const apiKeyFriendlyName = `twilio-cli for ${os.userInfo().username} on ${os.hostname()}`;
const apiKeyFriendlyName = this.getApiKeyFriendlyName();
let apiKey = null;

const twilioClient = this.getTwilioClient();
Expand Down
14 changes: 14 additions & 0 deletions test/commands/profiles/create.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const { expect, test, constants } = require('@twilio/cli-test');
const { Config, ConfigData } = require('@twilio/cli-core').services.config;
const ProfilesCreate = require('../../../src/commands/profiles/create');
const helpMessages = require('../../../src/services/messaging/help-messages');
const os = require('os');

describe('commands', () => {
describe('profiles', () => {
Expand Down Expand Up @@ -58,6 +59,19 @@ describe('commands', () => {
);
});

createTest()
.do(ctx => {
sinon.stub(os, 'hostname').returns('some_super_long_fake_hostname');
sinon.stub(os, 'userInfo').returns({
username: 'some_super_long_fake_username'
});
ctx.returned = ctx.testCmd.getApiKeyFriendlyName();
})
.it('truncates apiKeyFriendlyName to 64 characters', ctx => {
childish-sambino marked this conversation as resolved.
Show resolved Hide resolved
expect(ctx.returned.length).to.equal(64);
eshanholtz marked this conversation as resolved.
Show resolved Hide resolved
expect(ctx.returned).to.equal('twilio-cli for some_super_long_fake_username on some_super_long_');
});

createTest(['not-an-account-sid'])
.do(ctx => {
const fakePrompt = ctx.testCmd.inquirer.prompt;
Expand Down