Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

truncate friendlyName at 64 chars #133

Merged
merged 5 commits into from
Oct 29, 2019
Merged

truncate friendlyName at 64 chars #133

merged 5 commits into from
Oct 29, 2019

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Oct 25, 2019 •
edited
Loading

Fixes #134

@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #133 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   98.41%   98.41%   +<.01%     
==========================================
  Files          27       27              
  Lines         820      822       +2     
==========================================
+ Hits          807      809       +2     
  Misses         13       13
Impacted Files Coverage Δ
src/commands/profiles/create.js 96.77% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd874b...7a3082f. Read the comment docs.

@childish-sambino childish-sambino mentioned this pull request Oct 28, 2019
Closed
@eshanholtz eshanholtz merged commit 399bbcc into master Oct 29, 2019
@eshanholtz eshanholtz deleted the truncate-friendly-name branch October 29, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

twilio login returns Could not create an API Key.
3 participants
@eshanholtz @thinkingserious @childish-sambino