Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use error code 1 fore "unspecified error". #761

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

nbacquey
Copy link
Member

@nbacquey nbacquey commented Oct 9, 2024

Description

Error code 1 is usually used for

things went well and I need to answer 'no' or 'false' in a clean way

This PR changes the code of "unspecified error" from 1 to 10

Closes #611

Checklist

Checklist before merging:

  • CHANGELOG.md updated
  • README.md up-to-date

@nbacquey nbacquey requested a review from Xophmeister October 9, 2024 10:23
@nbacquey nbacquey merged commit 1a88ead into main Oct 9, 2024
9 checks passed
@nbacquey nbacquey deleted the nb/error_codes branch October 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use exit code 1 for "unspecified errors"
2 participants