Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use exit code 1 for "unspecified errors" #611

Closed
Xophmeister opened this issue Sep 6, 2023 · 0 comments · Fixed by #761
Closed

Don't use exit code 1 for "unspecified errors" #611

Xophmeister opened this issue Sep 6, 2023 · 0 comments · Fixed by #761
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter type: feature request

Comments

@Xophmeister
Copy link
Member

Currently, the Topiary CLI will exit with code 1 on an unspecified error (i.e., one it doesn't/cannot handle explicitly). This discussion suggests that exit code 1 has a conventional meaning of:

things went well and I need to answer 'no' or 'false' in a clean way

The unspecified error code should change to something else.
@Xophmeister Xophmeister mentioned this issue Sep 6, 2023
Merged
26 tasks
@ErinvanderVeen ErinvanderVeen added the epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter label Sep 28, 2023
@nbacquey nbacquey mentioned this issue Oct 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No longer use error code 1 fore "unspecified error". tweag/topiary
2 participants
@Xophmeister @ErinvanderVeen