Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create append/prepend versions of scope captures #576

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Create append/prepend versions of scope captures #576

merged 2 commits into from
Jul 13, 2023

Conversation

ErinvanderVeen
Copy link
Collaborator

Resolves #572 and unblocks #571

Creates atoms for the Scoping captures and introduces prepend/append versions of both scope_begin and scope_end.

@ErinvanderVeen ErinvanderVeen linked an issue Jul 13, 2023 that may be closed by this pull request
Scope prepend and append #572
Closed
nbacquey
nbacquey approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@nbacquey nbacquey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! You managed to expand the feature set while simplifying the implementation 👍

@ErinvanderVeen ErinvanderVeen merged commit d4dbf3f into main Jul 13, 2023
@ErinvanderVeen ErinvanderVeen deleted the 572-scope-prepend-and-append branch July 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbacquey nbacquey nbacquey approved these changes

@torhovland torhovland Awaiting requested review from torhovland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scope prepend and append
2 participants
@ErinvanderVeen @nbacquey