Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope prepend and append #572

Closed
ErinvanderVeen opened this issue Jul 10, 2023 · 1 comment · Fixed by #576
Closed

Scope prepend and append #572

ErinvanderVeen opened this issue Jul 10, 2023 · 1 comment · Fixed by #576
Assignees
@ErinvanderVeen
Labels
P1 critical: next release type: feature request

Comments

@ErinvanderVeen
Copy link
Collaborator

Issue #571 is best fixed by appending open_scope to the expression before the annotation. We should implement these new directives:

  • prepend_open_scope
  • append_open_scope
  • prepend_close_scope
  • append_close_scope
@ErinvanderVeen ErinvanderVeen added P2 major: an upcoming release type: feature request labels Jul 10, 2023
@torhovland
Copy link
Member

Perhaps we should change scopes to work like indenting, i.e. adding atoms for ScopeStart and ScopeEnd.

@ErinvanderVeen ErinvanderVeen added P1 critical: next release and removed P2 major: an upcoming release labels Jul 13, 2023
@ErinvanderVeen ErinvanderVeen self-assigned this Jul 13, 2023
@ErinvanderVeen ErinvanderVeen linked a pull request Jul 13, 2023 that will close this issue
Create append/prepend versions of scope captures #576
Merged
@ErinvanderVeen ErinvanderVeen mentioned this issue Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErinvanderVeen ErinvanderVeen

Labels
P1 critical: next release type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create append/prepend versions of scope captures tweag/topiary
2 participants
@torhovland @ErinvanderVeen