Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds nixpkgs_python_configure #97

Merged
merged 6 commits into from
Nov 13, 2019
Merged

Adds nixpkgs_python_configure #97

merged 6 commits into from
Nov 13, 2019

Conversation

aherrmann
Copy link
Member

  • Define nixpkgs constraint
    This is intended to move the nixpkgs platform constraint defined in rules_haskell into rules_nixpkgs so that it can be shared. It is used by nixpkgs_unix_configure in the exec_compatible_with attribute of the generated toolchain.
  • Update Bazel to version 1.1.0
    The update to Bazel 1.1.0 on rules_haskell (anything >0.29 really) motivates the introduction of nixpkgs_python_configure. See Update to Bazel 1.1 rules_haskell#1142.
  • Add nixpkgs_python_configure

    Define and register a Python toolchain provided by nixpkgs.
    Creates nixpkgs_packages for Python 2 or 3 py_runtime instances and a
    corresponding py_runtime_pair and toolchain. The toolchain is
    automatically registered and uses the constraint:
    "@io_tweag_rules_nixpkgs//nixpkgs/constraints:nixpkgs"

  • Adds a test-case for nixpkgs_python_configure.

This PR takes the definition of the nixpkgs constraint and the Bazel update out of #95. It should take precedence, as nixpkgs_python_configure is required to update Bazel in rules_haskell, which in turn is required to use nixpkgs_unix_configure in rules_haskell.

This is intended to move the `nixpkgs` platform constraint defined in
`rules_haskell` into `rules_nixpkgs` so that it can be shared.

It will be used by `nixpkgs_unix_configure` and
`nixpkgs_python_configure` in the `exec_compatible_with` attribute of
the generated toolchain.
Copy link
Contributor

@guibou guibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Congratulation for understanding the toolchains filtering mechanisms.

@aherrmann aherrmann merged commit bdc802f into master Nov 13, 2019
@aherrmann aherrmann deleted the python-toolchain branch November 13, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants