Define nixpkgs_unix_configure #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I insist that you move the descriptions into the commit messages? :) |
👍 Done |
|
See tweag/rules_sh#1. |
This uses `rules_sh`. However, users of `rules_nixpkgs` will only need to depend on `rules_sh` if they use this macro. Otherwise, `rules_nixpkgs` does not depend on `rules_sh`.
This adds a dependency on `rules_sh` for the test-suite.
|
I've updated this PR to use the |
mboes
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
I think nixpkgs_sh_posix_configure would be clearer as the name of the repository rule, so that it lines up with sh_posix_configure (which has to be called too). But I can live the current name.
If Nixpkgs ever gets ported to windows, we could in principle have nixpkgs_sh_cmd_configure in the future.
|
Sounds good, I've renamed everything accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rules_shsupport withnixpkgs_unix_configure, a macro to generate a Unix toolchain with commands provided by Nix.rules_shuses theconfigureattribute torepository_rulewhich was only introduced in Bazel 0.29.nixpkgsconstraintThis is intended to move the
nixpkgsplatform constraint defined inrules_haskellintorules_nixpkgsso that it can be shared. It is used bynixpkgs_unix_configurein theexec_compatible_withattribute of the generated toolchain.nixpkgs_unix_configureThis uses
rules_sh. However, users ofrules_nixpkgswill only need to depend onrules_shif they use this macro. Otherwise,rules_nixpkgsdoes not depend onrules_sh.nixpkgs_unix_configureThis adds a dependency on
rules_shfor the test-suite.