Add nodejs toolchain #222
Add nodejs toolchain #222
Conversation
betaboon
force-pushed
the
node-configure
branch
from
ae2684d to
413097c
Compare
|
I'm still working on this. currently i'm stuck at it running into |
betaboon
force-pushed
the
node-configure
branch
from
413097c to
022d217
Compare
|
thanks to @chancila i figured out that only a setting in |
|
Hi @betaboon , thank you for your contribution! Are you still working on it or do you need some assistance? |
|
@avdv I'm still working on this. planning to get the documentation ready in the next couple days. i could need some assistance on the issue of the required if there are any other pointers to get this in a ready state I'd gladly integrate them |
|
Hi @betaboon , sorry for the long delay. I had a look at this again. Also, I rebased onto master and added a missing dependency. An example for the toolchain would be nice to have. Thank you! |
betaboon
force-pushed
the
node-configure
branch
3 times, most recently
from
070f566 to
2f0be41
Compare
|
@avdv sorry for the long silence. i just rebased against master, included your changes, updated the nodejs and nixpkgs rules, added an example. i think this is now fine and ready :) |
|
Oh, I missed this update over the course of my holidays... I'm taking a look now. |
betaboon
force-pushed
the
node-configure
branch
from
2f0be41 to
9d209dc
Compare
|
i just rebased against master |
core/.bazelrc
Outdated
| @@ -1,4 +1,5 @@ | |||
| build --host_platform=@rules_nixpkgs_core//platforms:host | |||
| build --extra_execution_platforms=@io_tweag_rules_nixpkgs//nixpkgs/platforms:host | |||
There was a problem hiding this comment.
Can you explain why this is necessary? I commented it out and everything seemed to be fine.
There was a problem hiding this comment.
Also, after reverting the commit, CI was all green: https://github.com/tweag/rules_nixpkgs/actions/runs/3095774582
There was a problem hiding this comment.
iirc back then it failed to pick up the toolchain. i had some longer discussion in slack with someone that lead me to find this was required. maybe things changed since then ?
There was a problem hiding this comment.
OK, so let's skip this setting for now, we can add it back later if we see it's required.
betaboon
force-pushed
the
node-configure
branch
from
218f741 to
cd2e3b0
Compare
``` ERROR: /private/var/tmp/_bazel_runner/a4a3182e50c9460fa52b8c6c1e6f916f/sandbox/processwrapper-sandbox/9/execroot/io_tweag_rules_nixpkgs/bazel-out/darwin-fastbuild/bin/tests/run-test-invalid-nixpkgs-package.runfiles/io_tweag_rules_nixpkgs/WORKSPACE:20:27: fetching local_repository rule //external:rules_nixpkgs_nodejs: java.io.IOException: The repository's path is "./toolchains/nodejs" (absolute: "/private/var/tmp/_bazel_runner/a4a3182e50c9460fa52b8c6c1e6f916f/sandbox/processwrapper-sandbox/9/execroot/io_tweag_rules_nixpkgs/bazel-out/darwin-fastbuild/bin/tests/run-test-invalid-nixpkgs-package.runfiles/io_tweag_rules_nixpkgs/toolchains/nodejs") but it does not exist or is not a directory. ERROR: no such package '@rules_nixpkgs_nodejs//': The repository's path is "./toolchains/nodejs" (absolute: "/private/var/tmp/_bazel_runner/a4a3182e50c9460fa52b8c6c1e6f916f/sandbox/processwrapper-sandbox/9/execroot/io_tweag_rules_nixpkgs/bazel-out/darwin-fastbuild/bin/tests/run-test-invalid-nixpkgs-package.runfiles/io_tweag_rules_nixpkgs/toolchains/nodejs") but it does not exist or is not a directory. ```
|
Thank you, again! @betaboon |
No description provided.