Remove FAILED variable, use array length

tweag · Sep 21, 2022 · 218f741 · 218f741
1 parent 06ca7d1
commit 218f741
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/.github/build-and-test b/.github/build-and-test
@@ -10,12 +10,11 @@ SCRIPT_DIR="${SCRIPT_DIR%/*}"
 
 cd "$( dirname "$SCRIPT_DIR" )"
 
-declare -i FAILED=0
 declare -a FAILURES=( )
 
 function on_exit() {
     echo
-    if [[ "$FAILED" -gt 0 ]]; then
+    if [[ "${#FAILURES[@]}" -gt 0 ]]; then
         echo "error: running tests in ${FAILURES[@]} was not successful"
         exit 1
     elif [[ $? -eq 0 ]]; then
@@ -41,7 +40,6 @@ for dir in "${dirs[@]}"; do
 
     pushd $dir >/dev/null
     if ! bazel test //... ; then
-        let ++FAILED
         FAILURES+=( "$dir" )
     fi
     bazel shutdown