Add check to rgba-css-var
function for body or bg
#34699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most straightforward fix I can think of for this situation. It's definitely a my bad for not thinking about the new CSS var
--body-rgb
and there needing to be two separate CSS vars. This PR drops the--bs-body-rgb
for two separate ones (so it's a small breaking change), but keeps the.bg-body
and.text-body
intact without change. it also required duplicating the utilities maps a bit—so we can differentiate at the Sass map level between bg and color. I think this is an acceptable solution, but definitely want to hear thoughts.Fixes #34688.
/cc @ffoodd