Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: background color example for bg-body has invisible text #34688

Closed
coliff opened this issue Aug 5, 2021 · 4 comments · Fixed by #34699
Closed

Docs: background color example for bg-body has invisible text #34688

coliff opened this issue Aug 5, 2021 · 4 comments · Fixed by #34699
Labels
css v5

Comments

@coliff
Copy link
Contributor

coliff commented Aug 5, 2021

RE: https://getbootstrap.com/docs/5.1/utilities/background/

Looks like the .bg-body example here should have .text-white class so the text is visible.

image
@coliff
Copy link
Contributor Author

coliff commented Aug 5, 2021

Related issue on Shadows page examples:
https://getbootstrap.com/docs/5.1/utilities/shadows/

image

@GeoSot GeoSot added the docs label Aug 5, 2021
@GeoSot
Copy link
Member

GeoSot commented Aug 5, 2021

Nice catch @coliff 😃

@ffoodd
Copy link
Member

ffoodd commented Aug 5, 2021

.bg-body is not supposed to be darkish, see 5.0.

Can't debug for now but we somehow missed that in latest reviews 😞

@ffoodd ffoodd added css v5 and removed docs labels Aug 5, 2021
@mdo mdo mentioned this issue Aug 5, 2021
Merged
@mdo
Copy link
Member

mdo commented Aug 5, 2021

Ugh, my fault y'all 😞. Possible solution at #34699.

@ffoodd ffoodd mentioned this issue Aug 10, 2021
Closed
@ffoodd ffoodd mentioned this issue Aug 10, 2021
Closed
@coliff coliff mentioned this issue Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add check to rgba-css-var function for body or bg twbs/bootstrap
4 participants
@mdo @coliff @ffoodd @GeoSot