jQuery Fallback for unsupported CSS transitions (IE7/IE8/IE9) #3052
Conversation
|
+1 |
|
Nice one. |
|
nope - we want to treat animations as a progressive enhancement. thanks though |
|
How is adding a javascript fallback not progressive? |
|
I disagree, I am working on a carousel that I need to be compatable with IE7+ and the sliding animation is a requirement. So now I should abandon bootstrap? |
|
No - if you really need animations extend the plugin to add animations - should take like 5 minutes. |
|
...or use one of the many sliders that are out there. flexslider is pretty nice and has lot more options. no sense in dropping a great project over missing transitions in one plugin that is only noticeable in a subset of browsers. |
|
I switched to jcarousel for my carousel. It slides in IE7. Bootstrap is awesome but I'm probably not going to use if for this project because it does animations the CSS3 way. Don't get me wrong, I love CSS3 animations. But unfortunately I have to support IE7+ on this project, and I need the fanciness of animations. It would be nice if patches like these were accepted, or at least entertained, since even IE9 does not support CSS3 animations and it will be around for a while. I can understand the stance that animations are "progressive enhancement". But to the extend of isolating IE? Come on guys. We all have our grudges against IE and none of use use IE but it is used by our customers, and one of the beauties of Twitter Bootstrap is that it's supposed to be a quick way to build beautiful interfaces across all the modern browsers. CSS3 animation really shines on mobile devices, where it is hardware accelerated. But old-fashioned JS animations would work just as fine for the simple effects that are present in Bootstrap for browsers that aren't up-to-par. Just my two cents. |
|
I agree, I love the simplicity of this carousel, and the ease of implementing. I also like the idea of progressive enhancement. But, I think sliding isn't an enhancement, but basic functionality. A carrousel that doesn't slide, makes is pretty useless imho. And right now it doesn't slide for half of the visitors. And when you say "Bootstrap has evolved to include support for all major browsers (even IE7!) ", it is pretty confusing for most people, to find out that the slider doesn't work. You expect it to slide, when you give it the .slide class, at least in IE9. At least put up a warning, that it doesn't work for IE. It is not a problem for me, I just use this implementation, but I think a lot of people expect it to work, and don't know how to fix it. Adding something like this only costs max 15 lines, and only affects IE users.. |
|
This fixed worked like a charm. Thank you |
|
Why in the world was the pull request closed? This is such an easy win. Last I heard a few people still use Internet Explorer. |
|
Thanks for the fix. It just sucks that it won't be in the official release, which means we can't use a CDN version of bootstrap AND have this fix (unless there is a way to "patch" in this fix without changing core bootstrap files). While I agree with the concept of progressive enhancement, I do not think that applies in this case. A carousel that does not slide or animate IS NOT a carousel, it's something entirely different. The word carousel implies movement. Jumping from one image to the next instantly is not a carousel, it is a slideshow. So I think either the plugin should be renamed to slideshow, or this patch should be added, so that there is no confusion. I realize neither will likely be done, but I thought I would throw my opinion out there. On another note, I wish IE10's rendering engine would be force patched into all IE versions going back to IE6, with the new rendering engine triggered via meta tag. That would just about eliminate this whole nonsense of having to hack and patch to get IE to work like all other browsers do. Microsoft is literally holding back the web and it really sucks for developers like myself. I know they will never ever do that, but the very least they could do is allow IE9/10 to be installed on xp. |
|
Why this was not merged? Beats me :/ |
|
Is there a solution for Modal windows and Accordion features to show the slide in animations? |
|
I'm having this problem in ie9: When i toggle next, it has animation, but that item div dissappears and i can't see it anymore. It seems almost like falling. Anyone? |
|
As far as i can tell, i think is that it's not updating the next div with the "active" class. EDIT: I take that back. It's putting the class, i can't understand what can it be. |
|
You're a life saver. This fix works great. It's a damn shame they wont roll it in, it's like pulling toe-nails with these people. They can be as stubborn as the clients who refuse to upgrade their browsers. |
|
I agree with most people here. Bootstrap docs should have some disclaimers for something like this. "Does not work in IE" wouldn't look good for adoption purposes, but at least it's the truth. It would save people an hour or two. |
|
Thank you Barry for your work! Really helpful. I still don't understand though why there is no mention in docs about missing sliding functionality in IE. Could save me an hour.. |
|
I can't believe how incompetent the bootstrap developers are. They can't even support the most commonly used browser on the planet. yeah, I don't use IE, I hate it actually. But it ships with every PC sold. And the vast majority of those buyers just use the browser that came with their system. So as a developer I need to support it, not doing so out of spite is childish, amateurish, and just plain stupid. |
|
Just for anyone who is interested, the code still works in Bootstrap 3 (but the IE7 patch is not needed, because BS3 doesn't support that anyways). And I removed to lines about stopping the animation, to match the default behavior, see the changed file in https://gist.github.com/barryvdh/6155151#file-carousel-js-L141-L151 |
|
@barryvdh 👍 tyvm |
This commit provides a jQuery fallback, used when css transitions are not available.
It also changes carousel.less, because of an issue with the image dissapearing in IE7 (with this fallback).
I don't know if this is the fastest/best way, but it seems to be working on the sites I've tried it (and it is better then no transition..)
(As reported in Issue #2726)