Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for #20602 #21236

Merged
merged 6 commits into from
Nov 28, 2016
Merged

Replacement for #20602 #21236

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f06fc8
Fixed incorrect instruction: "Press ⌘ to copy"
Aug 31, 2016
aed9ed1
Updated to concatenate copy string
Sep 8, 2016
729d9a1
Updated the way the copy string concatenates
Sep 8, 2016
163bcfd
Removed semicolon line endings
Sep 8, 2016
b2d1f6f
Merge branch 'patch-5' of https://github.com/tjkohli/bootstrap into t…
mdo Nov 28, 2016
dcf5172
var not const or let
mdo Nov 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/assets/js/src/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
})

clipboard.on('error', function (e) {
var fallbackMsg = /Mac/i.test(navigator.userAgent) ? 'Press \u2318 to copy' : 'Press Ctrl-C to copy'
const modifierKey = /Mac/i.test(navigator.userAgent) ? '\u2318' : 'Ctrl-'
let fallbackMsg = 'Press ' + modifierKey + 'C to copy'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'fallbackMsg' is never reassigned. Use 'const' instead prefer-const
Unexpected string concatenation prefer-template

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be using ES5 and not ES6. let and const should be var. Then it will match the rest of the file and support all supported browsers.


$(e.trigger)
.attr('title', fallbackMsg)
Expand Down