Replacement for #20602 #21236
Replacement for #20602 #21236
Conversation
It needed to be "Press ⌘C to copy"
Updated copy command to concatenated string to prevent potential issues
As per excellent suggestion by @tomlutzenberger
| @@ -73,7 +73,8 @@ | |||
| }) | |||
|
|
|||
| clipboard.on('error', function (e) { | |||
| var fallbackMsg = /Mac/i.test(navigator.userAgent) ? 'Press \u2318 to copy' : 'Press Ctrl-C to copy' | |||
| const modifierKey = /Mac/i.test(navigator.userAgent) ? '\u2318' : 'Ctrl-' | |||
| let fallbackMsg = 'Press ' + modifierKey + 'C to copy' | |||
There was a problem hiding this comment.
'fallbackMsg' is never reassigned. Use 'const' instead prefer-const
Unexpected string concatenation prefer-template
There was a problem hiding this comment.
This should be using ES5 and not ES6. let and const should be var. Then it will match the rest of the file and support all supported browsers.
| @@ -73,7 +73,8 @@ | |||
| }) | |||
|
|
|||
| clipboard.on('error', function (e) { | |||
| var fallbackMsg = /Mac/i.test(navigator.userAgent) ? 'Press \u2318 to copy' : 'Press Ctrl-C to copy' | |||
| const modifierKey = /Mac/i.test(navigator.userAgent) ? '\u2318' : 'Ctrl-' | |||
| let fallbackMsg = 'Press ' + modifierKey + 'C to copy' | |||
There was a problem hiding this comment.
This should be using ES5 and not ES6. let and const should be var. Then it will match the rest of the file and support all supported browsers.
| @@ -73,7 +73,8 @@ | |||
| }) | |||
|
|
|||
| clipboard.on('error', function (e) { | |||
| var fallbackMsg = /Mac/i.test(navigator.userAgent) ? 'Press \u2318 to copy' : 'Press Ctrl-C to copy' | |||
| var modifierKey = /Mac/i.test(navigator.userAgent) ? '\u2318' : 'Ctrl-' | |||
| var fallbackMsg = 'Press ' + modifierKey + 'C to copy' | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
Unexpected string concatenation prefer-template
| @@ -73,7 +73,8 @@ | |||
| }) | |||
|
|
|||
| clipboard.on('error', function (e) { | |||
| var fallbackMsg = /Mac/i.test(navigator.userAgent) ? 'Press \u2318 to copy' : 'Press Ctrl-C to copy' | |||
| var modifierKey = /Mac/i.test(navigator.userAgent) ? '\u2318' : 'Ctrl-' | |||
There was a problem hiding this comment.
Unexpected var, use let or const instead no-var
This branch updates #20602 with latest from
v4-devso I can get tests passing and squash on merge.